[PATCH] D60459: SILoadStoreOptimizer pass mischedules s_add,s_addc with interfering s_lshl

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D60459#1459784 <https://reviews.llvm.org/D60459#1459784>, @ronlieb wrote:

> correction: the original input test did NOT have the instructions separated by more than 1 or 2 instructions The resultant output showed the large separation.
>  The default neighborhood of 10 is probably more than enough.


This is correction issue, not performance. Any kind of threshold is an error. If you did not find the def you probably need to bail.



================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:276
+      return &*I;
+  assert(0 && "Failed to find carry instr");
+  return nullptr;
----------------
It can be defined in another block. It can be also undef.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60459/new/

https://reviews.llvm.org/D60459