[PATCH] D60425: [GlobalISel][AArch64] Allow CallLowering to handle types

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM, some debug output would be nice to show what it is that we intend to implement



================
Comment at: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp:161
+          const LLT OrigTy(OrigVT);
+          // Just handle the case where the VA type is 2 * original type.
+          if (VATy.getNumElements() != OrigVT.getVectorNumElements() * 2)
----------------
Are we going to handle this? Debug output if so?


================
Comment at: llvm/lib/Target/AArch64/AArch64CallLowering.cpp:259
+      if (TLI.getNumRegistersForCallingConv(Ctx, CC, SplitEVTs[i]) > 1)
+        return false; // Don't yet handle extended types which need to be split.
 
----------------
Some debug output here would be nice?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60425/new/

https://reviews.llvm.org/D60425