[PATCH] D59266: [X86] Add support for {vex2}, {vex3}, and {evex} to the assembler to match gas. Use {evex} to improve the one our 32-bit AVX512 tests.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

Couple of minors but I think this is a good starting point - please make sure the issues you mentioned are included as TODOs somewhere or raised as bugs



================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:3140
+
+    assert(OriginalError == Match_InvalidOperand);
     // Recover location info for the operand if we know which was the problem.
----------------
missing assert message


================
Comment at: test/MC/X86/AVX-32.s:9
+// CHECK: encoding: [0xc4,0xe1,0x71,0x58,0x8c,0x82,0x10,0xe3,0x0f,0xe3]
+{vex3} vaddpd -485498096(%edx,%eax,4), %xmm1, %xmm1 
+
----------------
I take it you will be adding full vex3 testing as a separate (bulky) commit?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59266/new/

https://reviews.llvm.org/D59266