[PATCH] D54439: CMake: Make most target symbols hidden by default

Tue Apr 9 00:04:58 PDT 2019

hans added a comment.

In D54439#1457009 <https://reviews.llvm.org/D54439#1457009>, @tstellar wrote:

> In D54439#1456019 <https://reviews.llvm.org/D54439#1456019>, @hans wrote:
>
> > Looks good to me.
> >
> > Are there any buildbots that will catch if someone forgets to put an LLVM_EXTERNAL_VISIBILITY somewhere that's needed?
>
>
> I don't think so.  At least on linux this would require building with -DLLVM_BUILD_LLVM_DYLIB=ON and -DLLVM_LINK_LLVM_DYLIB=ON and I don't see any bots doing this.

I'm fine with the change itself, but that means it's pretty likely this is going to break sooner or later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54439/new/

https://reviews.llvm.org/D54439