[PATCH] D59938: [DebugInfo] Make InstrRange into a class, NFC
David Stenberg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 9 06:58:55 PDT 2019
dstenb marked 2 inline comments as done.
dstenb added inline comments.
================
Comment at: include/llvm/CodeGen/DbgEntityHistoryCalculator.h:33
public:
- using InstrRange = std::pair<const MachineInstr *, const MachineInstr *>;
+ class InstrRange {
+ const MachineInstr *Begin;
----------------
aprantl wrote:
> class Doxygen comment please
I took the comment that was listed above and doxygenized it. I made some adjustments, since the explanation about the range's end was not really correct for fragments.
(The class will change quite a bit in the follow-up patches, so the End explanation will not live for long, but I thought that it could still be good.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59938/new/
https://reviews.llvm.org/D59938
More information about the llvm-commits
mailing list