[PATCH] D59790: [DebugInfo][Docs] Document how variable location metadata is transformed through target codegen

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 194287.
jmorse marked 17 inline comments as done.
jmorse added a comment.

Many thanks for the reviews, I've juggled the text in the first third in response to comments,

Bjorn wrote:

> One more thing that could be described (not neccessarily in this patch):
> 
> dbg.declare is removed by ISel and the information is squirreled away in a table in the MachineFunction. Later DwarfDebug::collectVariableInfoFromMFTable is fetching the debug info using MF->getVariableDbgInfo(). That kind of explains why there is no DBG_DECLARE meta instruction, or any DBG_VALUE instructions when using -O0, which otherwise could be a mystery for someone not familiar with that

Ooof, that's another thing I was unaware of -- which is a great reason for it to be documented. (I'll work out where to drop that in shortly).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59790/new/

https://reviews.llvm.org/D59790

Files:
  docs/SourceLevelDebugging.rst

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59790.194287.patch
Type: text/x-patch
Size: 15885 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190409/09e97e73/attachment.bin>