[PATCH] D59303: [DebugInfo] Pass all values in DebugLocEntry's constructor, NFC
David Stenberg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 9 02:59:08 PDT 2019
dstenb added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h:103
public:
- DebugLocEntry(const MCSymbol *B, const MCSymbol *E, Value Val)
+ DebugLocEntry(const MCSymbol *B, const MCSymbol *E, ArrayRef<Value> Vals)
: Begin(B), End(E) {
----------------
aprantl wrote:
> Since you modified this, you are probably in a good position to add a doxygen comment explaining what the individual parameters mean? Alternatively renaming B to Begin might also suffice.
I renamed the variables and added a Doxygen comment to clarify that `End` is excluded from the range, and that `Vals` can't be empty.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59303/new/
https://reviews.llvm.org/D59303
More information about the llvm-commits
mailing list