[llvm] r357950 - [RuntimeDyld] Fix an ambiguous make_unique call.

[via llvm-commits]

Hi Lang,

After your fix here, there are still problems when building on Windows and the PS4 bot is still red:

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/24924/steps/build/logs/stdio

FAILED: tools/llvm-rtdyld/CMakeFiles/llvm-rtdyld.dir/llvm-rtdyld.cpp.obj 
C:\PROGRA~2\MIB055~1\2017\COMMUN~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\llvm-rtdyld -IC:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld -Iinclude -IC:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291 -wd4345 -wd4351 -wd4355 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4800 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /MD /O2 /Ob2   -UNDEBUG  /EHs-c- /GR- /showIncludes /Fotools\llvm-rtdyld\CMakeFiles\llvm-rtdyld.dir\llvm-rtdyld.cpp.obj /Fdtools\llvm-rtdyld\CMakeFiles\llvm-rtdyld.dir\ /FS -c C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp(765): error C2061: syntax error: identifier 'MSVCPExpected'
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp(770): error C2065: 'ExpectedLookupResult': undeclared identifier
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp(770): error C2923: 'std::promise': 'ExpectedLookupResult' is not a valid template type argument for parameter '_Ty'
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp(770): error C2672: 'std::make_shared': no matching overloaded function found
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp(770): error C3206: 'std::make_shared': invalid template argument for '_Ty', missing template argument list on class template 'std::promise'
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\memory(1864): note: see declaration of 'std::make_shared'
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp(771): error C3536: 'ResultP': cannot be used before it is initialized
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp(779): error C3536: 'ResultF': cannot be used before it is initialized
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp(780): error C3536: 'Result': cannot be used before it is initialized
C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\llvm-rtdyld\llvm-rtdyld.cpp(784): error C3536: 'I': cannot be used before it is initialized

Can you take a look?

Douglas Yung

-----Original Message-----
From: llvm-commits <llvm-commits-bounces at lists.llvm.org> On Behalf Of Lang Hames via llvm-commits
Sent: Monday, April 8, 2019 15:19
To: llvm-commits at lists.llvm.org
Subject: [llvm] r357950 - [RuntimeDyld] Fix an ambiguous make_unique call.

Author: lhames
Date: Mon Apr  8 15:19:05 2019
New Revision: 357950

URL: http://llvm.org/viewvc/llvm-project?rev=357950&view=rev
Log:
[RuntimeDyld] Fix an ambiguous make_unique call.

Modified:
    llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp

Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp?rev=357950&r1=357949&r2=357950&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldChecker.cpp Mon Apr  8 15:19:05 2019
@@ -853,7 +853,7 @@ RuntimeDyldChecker::RuntimeDyldChecker(
                       MCDisassembler *Disassembler,
                       MCInstPrinter *InstPrinter,
                       raw_ostream &ErrStream)
-    : Impl(make_unique<RuntimeDyldCheckerImpl>(
+    : Impl(llvm::make_unique<RuntimeDyldCheckerImpl>(
                                             std::move(IsSymbolValid),
                                             std::move(GetSymbolAddress),
                                             std::move(GetSymbolContent),


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits