[PATCH] D60404: Improve hashing for time profiler
Takuto Ikuta via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 8 21:16:45 PDT 2019
takuto.ikuta accepted this revision.
takuto.ikuta added a comment.
This revision is now accepted and ready to land.
LGTM with nit.
But I hope rnk take a look.
================
Comment at: llvm/lib/Support/TimeProfiler.cpp:137
<< escapeString(E.first)
- << "\", \"args\":{ \"count\":" << CountPerName[E.first]
- << ", \"avg ms\":" << (DurUs / CountPerName[E.first] / 1000)
- << "} },\n";
+ << "\", \"args\":{ \"count\":" << CountAndTotalPerName[E.first].first
+ << ", \"avg ms\":"
----------------
I prefer to reuse result of lookup for map here in L139.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60404/new/
https://reviews.llvm.org/D60404
More information about the llvm-commits
mailing list