[PATCH] D60421: [ThinLTO] Fix ThinLTOCodegenerator to export llvm.used symbols

[Steven Wu via Phabricator via llvm-commits]

steven_wu added a comment.

In D60421#1458858 <https://reviews.llvm.org/D60421#1458858>, @tejohnson wrote:

> What part of the patch caused the need to change the internalize action to do promote+internalize in one go?


It is to test the fix in the patch (llvm.used) which doesn't reproduce with llvm-lto without change. In the previous patch, I updated promote directly to behave the same as ThinLTOCodegenerator and I thought no tests is broken. It turns out my local configuration is wrong and some tests are labelled unsupported.
It turns out there are lots of weak resolution tests rely on the current configuration of promote function, which is testing the output from a pipeline doesn't match ThinLTOCodeGenerator. Merging promote + internalize and matching that with ThinLTOCodeGenerator is the best solution I have right now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60421/new/

https://reviews.llvm.org/D60421