[PATCH] D59303: [DebugInfo] Pass all values in DebugLocEntry's constructor, NFC

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 8 11:32:56 PDT 2019


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h:103
 public:
-  DebugLocEntry(const MCSymbol *B, const MCSymbol *E, Value Val)
+  DebugLocEntry(const MCSymbol *B, const MCSymbol *E, ArrayRef<Value> Vals)
       : Begin(B), End(E) {
----------------
Since you modified this, you are probably in a good position to add a doxygen comment explaining what the individual parameters mean? Alternatively renaming B to Begin might also suffice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59303/new/

https://reviews.llvm.org/D59303





More information about the llvm-commits mailing list