[PATCH] D58245: Remove no-op code.

Chih-Mao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 8 10:48:34 PDT 2019


PkmX added a comment.
Herald added a subscriber: MaskRay.

GNU as for RISC-V does actually produce out-of-order relocations so lld cannot assume they are always sorted by offset. This was previously discussed at:

https://github.com/riscv/riscv-binutils-gdb/issues/107

Some parts of the code in lld like `OffsetGetter::get()` for merging `.eh_frame` also depends on the relocations being sorted by offset, so sorting here isn't simply a performance optimization to do binary search.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58245/new/

https://reviews.llvm.org/D58245





More information about the llvm-commits mailing list