[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

MyDeveloperDay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 8 03:58:00 PDT 2019


MyDeveloperDay added a comment.

In D60363#1458034 <https://reviews.llvm.org/D60363#1458034>, @klimek wrote:

> +1 to quite some overlap in the tests. I'd have expected three test cases:
>
> 1. ; line comment
> 2. ; C-comment
> 3. no semi


Yes, sorry about that.. the tests were left over from my debugging investigation, I originally thought the bug was caused by the comment in the arguments and not by the comment after the `;`, I'll update the patch to remove necessary test cases and resubmit


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60363/new/

https://reviews.llvm.org/D60363





More information about the llvm-commits mailing list