[PATCH] D60017: [git] Be more specific when looking for llvm-svn

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: llvm/utils/git-svn/git-llvm:417-418
+    # be the authoritative one.
+    # Also, we need to check for leading/trailing whitespace to deal with
+    # git log formatting.
+    svn_match_iter = re.finditer('^\s*llvm-svn: (\d{5,7})\s*$', commit_msg, re.MULTILINE)
----------------
If you use `git log -1 --format=%b` then you will get just the raw log message, without extraneous whitespace.


================
Comment at: llvm/utils/git-svn/git-llvm:496
+      svn_rev = lookup_llvm_svn_id(args.revision)
+      git_hash = args.revision
 
----------------
The argument might be a git ref name (e.g. HEAD~1), so we shouldn't pass the user's specification directly into the output.

I think lookup_llvm_svn_id can return both the git hash and svn id, since it's already looked up both.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60017/new/

https://reviews.llvm.org/D60017