[PATCH] D49084: FileCheck: Add support for numeric variables and expressions

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre abandoned this revision.
thopre added a comment.

In D49084#1384876 <https://reviews.llvm.org/D49084#1384876>, @jhenderson wrote:

> I definitely think that you need to fragment this up into small incremental patches, as I've found I'm not getting enough time to digest the whole thing at once (and I'm guessing the same goes for other reviewers). If you could try to find incremental ways of doing things that would be great. One example would be to add the command-line switches as non-functional switches first (make them hidden until you're ready for them to be published), then incrementally add features (and expand testing) to them. Similarly accepting some forms of the pattern etc could be done in one change (but do nothing with them) and then add more functionality over time.


Done in patch series starting from https://reviews.llvm.org/D60381. Thus closing this revision. I've just noticed there's a few of your comments (casing of function notably) I haven't incorporated in the new patch series. I'll address them now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49084/new/

https://reviews.llvm.org/D49084