[PATCH] D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 6 20:38:37 PDT 2019


Higuoxing added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4563
+                                         const uint8_t *VersymBuf) {
   DictScope SS(W, "Version symbols");
 
----------------
Here, I changed a behavior of this tool. In this patch, if no versioning section appeared, we won't print anything. Before this patch, we will print:

```
Version symbols {
}
SHT_GNU_verdef {
}
SHT_GNU_verneed {
}
```

I don't know if this could be accepted


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60321/new/

https://reviews.llvm.org/D60321





More information about the llvm-commits mailing list