[PATCH] D60370: [gn] Support for building libunwind

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/utils/gn/secondary/libunwind/src/BUILD.gn:20
+if (target_os == "mac") {
+  unwind_headers += [ "../include/mach-o/compact_unwind_encoding.h" ]
+}
----------------
probably need a comment here to keep the sync script happy?


================
Comment at: llvm/utils/gn/secondary/libunwind/src/BUILD.gn:23
+
+unwind_sources = [
+  "libunwind.cpp",
----------------
Does making this a source_set and having both libs depend on that not work for static_library?


================
Comment at: llvm/utils/gn/secondary/libunwind/src/BUILD.gn:51
+  cflags_c = [ "-std=c99" ]
+  cflags_cc = [ "-fno-rtti" ]
+  include_dirs = [ "//libunwind/include" ]
----------------
why do you remove config_nortti and then add -fno-rtti back in here? Can't you just not remove it in the first place?


================
Comment at: llvm/utils/gn/secondary/libunwind/src/BUILD.gn:77
+    sources = unwind_sources
+    # TODO: sync_source_lists_from_cmake.py doesn't handle these.
+    #public = unwind_headers
----------------
It looks for .h files, no matter if in a target or not. Does not adding this to public help the script? That'd surprise me.


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60370/new/

https://reviews.llvm.org/D60370