[PATCH] D59926: Constant folding sometimes creates large constants even though a smaller constant is used multiple times

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

This still feels incredibly intrusive.
At this stage, you don't know if you will have issues with the immediates you would get.
This is also extremely pessimistic, as this bans creation of *all* new constants.
It does not attempt to model whether that new immediate would or would not be a problem.

TLDR: i believe this needs cost/benefit analysis (test-suite codesize,performance change report) + RFC on llvm-dev.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59926/new/

https://reviews.llvm.org/D59926