[PATCH] D54439: CMake: Make most target symbols hidden by default

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 5 16:02:36 PDT 2019


tstellar added a comment.

In D54439#1456019 <https://reviews.llvm.org/D54439#1456019>, @hans wrote:

> Looks good to me.
>
> Are there any buildbots that will catch if someone forgets to put an LLVM_EXTERNAL_VISIBILITY somewhere that's needed?


I don't think so.  At least on linux this would require building with -DLLVM_BUILD_LLVM_DYLIB=ON and -DLLVM_LINK_LLVM_DYLIB=ON and I don't see any bots doing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54439/new/

https://reviews.llvm.org/D54439





More information about the llvm-commits mailing list