[PATCH] D60292: [AMDGPU] predicate and feature refactoring

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPU.td:146-150
+def FeatureGFX8Insts : SubtargetFeature<"gfx8-insts",
+  "GFX8Insts",
   "true",
-  "Additional instructions for VI+"
+  "Additional instructions for GFX8+"
 >;
----------------
arsenm wrote:
> This is a compatibility breaking change, but we haven't been trying too hard to not break bitcode
We managed to have two features at the same time, vi-insts and gfx8-insts, so compatibility is already compromised. This will just combine them from this point on.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60292/new/

https://reviews.llvm.org/D60292