[PATCH] D59973: [SLP] Refactoring of the operand reordering code.

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:3224
+// Perform operand reordering on the instructions in VL.
+void BoUpSLP::reorderInputsAccordingToOpcode(ArrayRef<Value *> VL,
+                                             SmallVectorImpl<Value *> &Left,
----------------
ABataev wrote:
> Maybу it would be better to encapsulate all this reordering in the `VLOperands` class rather than exposing some low-level transformators like `swap` etc.?
Good point, I don't see any reason why reordering should not be a method of VLOperands.  I moved all the reordering related methods inside VLOperands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59973/new/

https://reviews.llvm.org/D59973