[PATCH] D60345: [TSan][libdispatch] Fix test

[Julian Lettner via Phabricator via llvm-commits]

yln created this revision.
Herald added subscribers: llvm-commits, Sanitizers, kubamracek.
Herald added projects: Sanitizers, LLVM.

Would this simpler test do the trick as well?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60345

Files:
  compiler-rt/test/tsan/Darwin/gcd-barrier.mm


Index: compiler-rt/test/tsan/Darwin/gcd-barrier.mm
===================================================================
--- compiler-rt/test/tsan/Darwin/gcd-barrier.mm
+++ compiler-rt/test/tsan/Darwin/gcd-barrier.mm
@@ -13,34 +13,20 @@
   barrier_init(&barrier, 2);
 
   dispatch_queue_t q = dispatch_queue_create("my.queue", DISPATCH_QUEUE_CONCURRENT);
-  dispatch_queue_t bgq = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
 
-  dispatch_async(bgq, ^{
-    dispatch_sync(q, ^{
-      global = 42;
-    });
-    barrier_wait(&barrier);
+  dispatch_async(q, ^{
+    global = 42;
   });
-
-  dispatch_async(bgq, ^{
-    barrier_wait(&barrier);
-    dispatch_barrier_sync(q, ^{
-      global = 43;
-    });
-
-    dispatch_async(bgq, ^{
-      barrier_wait(&barrier);
-      global = 44;
-    });
+  dispatch_barrier_async(q, ^{
+    global = 43;
+  });
+  dispatch_async(q, ^{
+    global = 44;
 
     barrier_wait(&barrier);
-    
-    dispatch_sync(dispatch_get_main_queue(), ^{
-      CFRunLoopStop(CFRunLoopGetCurrent());
-    });
   });
 
-  CFRunLoopRun();
+  barrier_wait(&barrier);
   fprintf(stderr, "Done.\n");
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60345.193982.patch
Type: text/x-patch
Size: 1141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190405/4ec245ce/attachment.bin>