[PATCH] D60331: [gn] Support for building compiler-rt builtins

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Thanks! lgtm with the comment for the one one-line sources line as discussed.



================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:154
+  umodti3.c
+)
 
----------------
(the more common style is to indent the ) by two. unless you're being consistent with other places in this file, consider indenting the closing parens)


================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn:365
+
+  if (target_cpu == "ppc") {
+    sources += [
----------------
ppc64 too, or are these 32-bit?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60331/new/

https://reviews.llvm.org/D60331