[PATCH] D59658: [LLVM-C] Add bindings to insert basic blocks

[Robert Widmann via Phabricator via llvm-commits]

CodaFi added a comment.

In D59658#1456672 <https://reviews.llvm.org/D59658#1456672>, @whitequark wrote:

> I think the names are confusing. Why not something like `LLVMInsertExistingBasicBlock` and `LLVMAppendExistingBasicBlock`?


Like to match `LLVMInsertBasicBlock` and `LLVMAppendBasicBlock`?  The former's semantics don't really match its pair function.  `LLVMInsertBasicBlock` is used to insert before another block where  `LLVMInsertBasicBlockAfterInsertBlock` inserts at the current global insertion point. I agree with the `LLVMAppendExistingBasicBlock ` name change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59658/new/

https://reviews.llvm.org/D59658