[PATCH] D60331: [gn] Support for building compiler-rt builtins

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

lgtm except for minor comments:



================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/BUILD.gn:3
+  deps = [
+    "builtins",
+  ]
----------------
`llvm/utils/gn/gn.py help label`: "Stylistically, we prefer to use absolute paths for all non-file-local references"


================
Comment at: llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn:30
+  sources = [
+    "absvdi2.c",
+    "absvsi2.c",
----------------
Edit llvm/utils/gn/build/sync_source_lists_from_cmake.py and modify gn_cpp_re and cmake_cpp_re to contain `|c` after cpp and make sure the script is still happy. You probably have to move a few closing parens in compiler-rt/lib/builtins/CMakeLists.txt to the next line (which is by far the more common style in LLVM's cmake, so this will make the cmake build more consistent too).

Hm, looking at that file, we might want to add `|S` there too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60331/new/

https://reviews.llvm.org/D60331