[PATCH] D60253: [gn] Support for building runtimes

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/utils/gn/secondary/libcxx/src/BUILD.gn:4
+
+declare_args() {
+  # Build libc++ with definitions for operator new/delete.
----------------
phosek wrote:
> pcc wrote:
> > Do you really need all of these arguments? I would recommend only implementing the default behavior for most of them except for the ones that you actually need.
> > 
> > (Same comment elsewhere.)
> We need these for Fuchsia and/or libFuzzer (which is also needed for Fuchsia).
Could you add them when you add Fuchsia and/or libFuzzer support, then? I feel like there ought to be a better way of making these customizations. For example, you could make the Fuchsia customizations conditional on `current_os == "fuchsia"`, and the libc++ that libFuzzer uses could be built inside a custom toolchain with something like `is_libfuzzer_build` set and all of the libFuzzer customizations would be conditional on that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60253/new/

https://reviews.llvm.org/D60253