[PATCH] D60328: [gn] Make -no-exceptions flag a config

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 5 11:31:22 PDT 2019


phosek created this revision.
phosek added a reviewer: thakis.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This allows it to be disabled for targets that need exceptions
like libunwind, libc++abi and libc++.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60328

Files:
  llvm/utils/gn/build/BUILD.gn
  llvm/utils/gn/build/BUILDCONFIG.gn


Index: llvm/utils/gn/build/BUILDCONFIG.gn
===================================================================
--- llvm/utils/gn/build/BUILDCONFIG.gn
+++ llvm/utils/gn/build/BUILDCONFIG.gn
@@ -5,6 +5,7 @@
 shared_binary_target_configs = [
   "//llvm/utils/gn/build:compiler_defaults",
   "//llvm/utils/gn/build:llvm_code",
+  "//llvm/utils/gn/build:no_exceptions",
   "//llvm/utils/gn/build:no_rtti",
   "//llvm/utils/gn/build:thin_archive",
   "//llvm/utils/gn/build:warn_covered_switch_default",
Index: llvm/utils/gn/build/BUILD.gn
===================================================================
--- llvm/utils/gn/build/BUILD.gn
+++ llvm/utils/gn/build/BUILD.gn
@@ -31,7 +31,6 @@
     cflags += [ "-fdiagnostics-color" ]
     cflags_cc = [
       "-std=c++11",
-      "-fno-exceptions",
       "-fvisibility-inlines-hidden",
     ]
   } else {
@@ -139,6 +138,10 @@
   }
 }
 
+config("no_exceptions") {
+  cflags_cc = [ "-fno-exceptions" ]
+}
+
 config("no_rtti") {
   if (current_os == "win") {
     cflags_cc = [ "/GR-" ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60328.193921.patch
Type: text/x-patch
Size: 1028 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190405/99d44397/attachment.bin>


More information about the llvm-commits mailing list