[PATCH] D60310: [ProfileData] Migrate SampleProf{Reader,Writer} functions from error_code/ErrorOr to Error/Expected

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: wmi, danielcdh, davidxl.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This fixes one FIXME (moving away from std::error_code) left by D20592 <https://reviews.llvm.org/D20592>
and fixes some inadvertently discarded return values. They were caught
because Error is marked as LLVM_NODISCARD.


Repository:
  rL LLVM

https://reviews.llvm.org/D60310

Files:
  include/llvm/ProfileData/SampleProf.h
  include/llvm/ProfileData/SampleProfReader.h
  include/llvm/ProfileData/SampleProfWriter.h
  lib/ProfileData/SampleProf.cpp
  lib/ProfileData/SampleProfReader.cpp
  lib/ProfileData/SampleProfWriter.cpp
  lib/Target/X86/X86InsertPrefetch.cpp
  lib/Transforms/IPO/SampleProfile.cpp
  tools/llvm-profdata/llvm-profdata.cpp
  unittests/ProfileData/SampleProfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60310.193844.patch
Type: text/x-patch
Size: 68719 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190405/f9f58f17/attachment.bin>