[PATCH] D60307: ELF: Move verneed tracking data structures out of VersionNeedSection.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:2796-2797
+    File.Vernauxs.resize(File.Verdefs.size());
+  if (File.Vernauxs[SS->VerdefIndex] == 0)
+    File.Vernauxs[SS->VerdefIndex] = ++SharedFile::VernauxNum + getVerDefNum();
+  SS->VersionId = File.Vernauxs[SS->VerdefIndex];
----------------
So the computed numbers start with one plus the number of versions in given version scripts, but it isn't easy to see that from the code. I'd write a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60307/new/

https://reviews.llvm.org/D60307