[PATCH] D60297: [COFF] Pack Name in Symbol as is done in ELF
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 4 17:43:32 PDT 2019
ruiu added inline comments.
================
Comment at: lld/COFF/Symbols.h:111
+ // Symbol name length. Assume symbol lengths fit in a 32-bit integer.
+ unsigned NameLen;
+
----------------
I'd use uint32_t to match the comment.
================
Comment at: lld/COFF/Symbols.h:111
+ // Symbol name length. Assume symbol lengths fit in a 32-bit integer.
+ unsigned NameLen;
+
----------------
ruiu wrote:
> I'd use uint32_t to match the comment.
We have the same hack for ELF, and we name these variables NameSize and NameData.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60297/new/
https://reviews.llvm.org/D60297
More information about the llvm-commits
mailing list