[PATCH] D59050: [InterleavedAccessAnalysis] Use unordered_map to avoid tombstone insertion.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 4 15:03:21 PDT 2019


efriedma added a comment.

That layout generally makes sense, sure. Maybe you could get away with one bit per slot by sticking a bit to distinguish between either empty/tombstone into the main table, but I guess it's not really a big deal either way if you're talking about one or two bits per entry. I guess two bits makes failed lookups faster.

A higher-quality MapVector, which doesn't store two copies of the key, would also be generally nice to have... although the overhead is higher for small keys/values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59050/new/

https://reviews.llvm.org/D59050





More information about the llvm-commits mailing list