[PATCH] D60226: [ThinLTO] Fix ThinLTOCodegenerator to export llvm.used symbols

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 4 14:21:54 PDT 2019


tejohnson added a comment.

In D60226#1453856 <https://reviews.llvm.org/D60226#1453856>, @steven_wu wrote:

> Also do note, I did a quick benchmark on thin-link time for libLTO.dylib. thin-link was 2.6s before the change vs. 4.0s after the change. Building IRSymtab during thin-link does introduce non-negligible overhead. It might be possible to build them async in threads to reduce the overhead.


@pcc is this surprising? Typically we should just be loading it out of the bitcode file. There are cases where it has to be rebuilt, but theoretically those should be exceptions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60226/new/

https://reviews.llvm.org/D60226





More information about the llvm-commits mailing list