[PATCH] D60184: [FastISel] Fix crash for gc.relocate lowring

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 4 10:38:24 PDT 2019


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/requested change applied in both places.



================
Comment at: lib/CodeGen/SelectionDAG/StatepointLowering.h:70
+    // We are not interested in lowering dead instructions.
+    if (RelocCall.hasNUsesOrMore(1))
+      PendingGCRelocateCalls.push_back(&RelocCall);
----------------
idiomatic way to write this would be:
if (!RelocCall->use_empty())


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60184/new/

https://reviews.llvm.org/D60184





More information about the llvm-commits mailing list