[PATCH] D60256: [InstCombine][X86] Expand MOVMSK to generic IR (PR39927)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 4 09:51:25 PDT 2019


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: test/Transforms/InstCombine/X86/x86-movmsk.ll:399
 
 ; Negative test - bitcast from scalar.
 
----------------
spatel wrote:
> Stale comment. Could mark this a TODO, but it might cause more harm than good:
>   %fourbits = sext i1 %x to i4
>   %r = zext i4 %fourbits to i32 
Just to be clear - this patch doesn't affect the codegen for this: https://godbolt.org/z/dsKCrY


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60256/new/

https://reviews.llvm.org/D60256





More information about the llvm-commits mailing list