[PATCH] D60265: [LoopUnroll] Allow unrolling if the unrolled size does not exceed loop size.
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 4 09:14:14 PDT 2019
paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.
LGTM. Just a couple little comments, but none of them are critical:
- In D60266 <https://reviews.llvm.org/D60266> you have some code size numbers; it would be nice to have something similar here.
- It would be nice to have a test with just the optsize attribute, since `optForSize()` will also return true if only that attribute is set.
- If the intention here is only -Oz/minsize, you might want to replace the call to `optForSize()` with `optForMinSize()`. This seems like an appropriate change for -Os/optsize though, so I don't think it's necessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60265/new/
https://reviews.llvm.org/D60265
More information about the llvm-commits
mailing list