[PATCH] D60264: [ConstantRange] Add isNegative() and isNonNegative() methods
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 4 08:27:41 PDT 2019
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
LG, thank you.
================
Comment at: llvm/unittests/IR/ConstantRangeTest.cpp:1664
+ EXPECT_EQ(AllNonNegative, CR.isAllNonNegative());
+ });
+}
----------------
Hmm, can we also check that
```
if(!CR.isEmptySet() && !CR.isFullSet())
EXPECT_NE(AllNegative, AllNonNegative);
```
?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60264/new/
https://reviews.llvm.org/D60264
More information about the llvm-commits
mailing list