[PATCH] D60228: [X86] Merge the different Jcc instructions for each condition code into single instructions that store the condition code as an operand.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 4 08:08:39 PDT 2019


craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1331
+      EmitByte(BaseOpcode, CurByte, OS);
+    }
 
----------------
RKSimon wrote:
> Worth doing a LLVM_FALLTHROUGH here?
By hoisting Adder out of the switch and initializing to 0?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60228/new/

https://reviews.llvm.org/D60228





More information about the llvm-commits mailing list