[PATCH] D59973: [SLP] Refactoring of the operand reordering code.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: test/Transforms/SLPVectorizer/X86/operandorder.ll:47
 ; CHECK-NEXT:    store <2 x double> [[TMP4]], <2 x double>* [[TMP5]], align 4
 ; CHECK-NEXT:    br i1 undef, label [[LP]], label [[EXT:%.*]]
 ; CHECK:       ext:
----------------
ABataev wrote:
> vporpo wrote:
> > RKSimon wrote:
> > > Hmm - these tests are called 'preserve_broadcast' and we're not preserving the broadcasts any more.... This might not be a bad thing but it'd be good to confirm (and possibly rename the tests if everything is good)
> > I am not sure why we would prefer to build a broadcast instead of vectorizing the loads.
> > @ABataev any idea about this?
> I agree, that the vectorization of loads is better.
OK - rename as "shuffle_vs_broadcast" or something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59973/new/

https://reviews.llvm.org/D59973