[PATCH] D58804: AMDGPU/GlobalISel: Implement select for 32-bit G_ADD

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 4 06:27:22 PDT 2019


arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/GlobalISel/inst-select-add.mir:40
+
+...
----------------
tstellar wrote:
> arsenm wrote:
> > 64-bit scalar at least looks like is already handled that should have a test here
> Where did you see this?  I tried to add the test, but it complained that 64-bit G_ADD was not legal.
bool AMDGPUInstructionSelector::selectG_ADD(MachineInstr &I) const {
Creates an S_ADD_U32 + S_ADDC_U32 pair


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58804/new/

https://reviews.llvm.org/D58804





More information about the llvm-commits mailing list