[PATCH] D59626: Add MachineDCE pass after RenameIndependentSubregs
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 3 11:53:56 PDT 2019
craig.topper added a comment.
I don't think X86 needs this pass. Everything here looks like bad test construction or the issue in speculative load hardening.
================
Comment at: test/CodeGen/X86/combine-bitselect.ll:657
br label %bb1
}
----------------
rampitec wrote:
> craig.topper wrote:
> > This test should be fixed to not be an infinite loop. The middle end wouldn't have given this code to the backend.
> Does it change anything? The test has no side effects anyway.
> I am not really sure what does it test, so I am a little afraid to touch it. I can add an option not run extra DCE pass here if needed.
I updated this test in trunk so that it no longer has an infinite loop that would allow things to be deleted.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59626/new/
https://reviews.llvm.org/D59626
More information about the llvm-commits
mailing list