[PATCH] D60196: [llvm-symbolizer] Allow more flexible usage of -e

[Igor Kudrin via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL357676: [llvm-symbolizer] Allow more flexible usage of -e. (authored by ikudrin, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D60196?vs=193499&id=193673#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60196/new/

https://reviews.llvm.org/D60196

Files:
  llvm/trunk/test/tools/llvm-symbolizer/basic.s
  llvm/trunk/test/tools/llvm-symbolizer/flag-grouping.test
  llvm/trunk/tools/llvm-symbolizer/llvm-symbolizer.cpp


Index: llvm/trunk/test/tools/llvm-symbolizer/basic.s
===================================================================
--- llvm/trunk/test/tools/llvm-symbolizer/basic.s
+++ llvm/trunk/test/tools/llvm-symbolizer/basic.s
@@ -17,7 +17,9 @@
 
 # Check --obj aliases --exe, -e
 # RUN: llvm-symbolizer 0xa 0xb --exe=%t.o | FileCheck %s
+# RUN: llvm-symbolizer 0xa 0xb -e %t.o | FileCheck %s
 # RUN: llvm-symbolizer 0xa 0xb -e=%t.o | FileCheck %s
+# RUN: llvm-symbolizer 0xa 0xb -e%t.o | FileCheck %s
 
 # CHECK: basic.s:5:0
 # CHECK: basic.s:6:0
Index: llvm/trunk/test/tools/llvm-symbolizer/flag-grouping.test
===================================================================
--- llvm/trunk/test/tools/llvm-symbolizer/flag-grouping.test
+++ llvm/trunk/test/tools/llvm-symbolizer/flag-grouping.test
@@ -1,4 +1,7 @@
 RUN: llvm-symbolizer -apCi -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
+RUN: llvm-symbolizer -apCie %p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
+RUN: llvm-symbolizer -apCie=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
+RUN: llvm-symbolizer -apCie%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
 
 CHECK: some text
 CHECK: 0x40054d: inctwo
Index: llvm/trunk/tools/llvm-symbolizer/llvm-symbolizer.cpp
===================================================================
--- llvm/trunk/tools/llvm-symbolizer/llvm-symbolizer.cpp
+++ llvm/trunk/tools/llvm-symbolizer/llvm-symbolizer.cpp
@@ -94,10 +94,9 @@
 static cl::alias
 ClBinaryNameAliasExe("exe", cl::desc("Alias for -obj"),
                      cl::NotHidden, cl::aliasopt(ClBinaryName));
-static cl::alias
-ClBinaryNameAliasE("e", cl::desc("Alias for -obj"),
-                   cl::NotHidden, cl::aliasopt(ClBinaryName));
-
+static cl::alias ClBinaryNameAliasE("e", cl::desc("Alias for -obj"),
+                                    cl::NotHidden, cl::Grouping, cl::Prefix,
+                                    cl::aliasopt(ClBinaryName));
 
 static cl::opt<std::string>
     ClDwpName("dwp", cl::init(""),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60196.193673.patch
Type: text/x-patch
Size: 2016 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190404/d304b05f/attachment.bin>