[PATCH] D60242: Add IR support, ELF section and user documentation for partitioning feature.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/docs/Partitions.rst:15
+but unlike a shared object, the main partition and the loadable partitions
+share a virtual address space, and each loadable partition is assigned a
+fixed load address relative to the load address of the main partition. This
----------------
share a virtual address space at link time?


================
Comment at: lld/docs/Partitions.rst:27-31
+could be a group of functions that expose the functionality implemented by
+the partition. The intent is that in order to use a loadable partition, the
+program will use ``dlopen``/``dlsym`` or similar functions to dynamically
+load the partition at its assigned address, look up an entry point by name
+and call it. Note, however, that the standard ``dlopen`` function does not
----------------
Each partition's entry point address is fixed at link-time, so I wonder why you chose to get the address of the entry point by name. If you use the entry point by address, you can possibly remove the symbol table, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60242/new/

https://reviews.llvm.org/D60242