[PATCH] D60039: Fix the bug of garbage collection of siod.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: MultiSource/Applications/siod/slib.c:1273
     ++heap;}
+#if defined(linux)
+ // On linux, some register is mangled in jmp buffer, so object that
----------------
LuoYuanke wrote:
> MaskRay wrote:
> > `#ifdef __GLIBC__`
> > 
> > musl doesn't mangle RIP,RSP,RBP.
> Thank you for the hint. But I don't find macro__GLIBC__ with "cpp -dM". Is __GLIBC__ an internal macro of compiler? 
> I assume on linux getcontext() is supported, so whenever getcontext() is supported we can use it.
> So how about just fix the comments to tell developer on glibc (instead of on linux) register is mangled in jmp buffer?
> 
glibc `stdio.h` includes `features.h` which defines `__GLIBC__`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60039/new/

https://reviews.llvm.org/D60039