[PATCH] D60252: [dwarfdump] Make -arch accept alternative spellings
Dave Lee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 3 23:34:21 PDT 2019
kastiglione updated this revision to Diff 193664.
kastiglione added a comment.
Remove unintended changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60252/new/
https://reviews.llvm.org/D60252
Files:
llvm/test/tools/llvm-dwarfdump/X86/archive.test
llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
Index: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
===================================================================
--- llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -258,12 +258,11 @@
return true;
if (auto *MachO = dyn_cast<MachOObjectFile>(&Obj)) {
- std::string ObjArch =
- Triple::getArchTypeName(MachO->getArchTriple().getArch());
+ auto ObjArch = MachO->getArchTriple().getArch();
for (auto Arch : ArchFilters) {
// Match name.
- if (Arch == ObjArch)
+ if (Triple(Arch).getArch() == ObjArch)
return true;
// Match architecture number.
Index: llvm/test/tools/llvm-dwarfdump/X86/archive.test
===================================================================
--- llvm/test/tools/llvm-dwarfdump/X86/archive.test
+++ llvm/test/tools/llvm-dwarfdump/X86/archive.test
@@ -11,6 +11,12 @@
I386: file format Mach-O 32-bit i386
I386-NOT: 64-bit
+RUN: llvm-dwarfdump --debug-info %S/../../dsymutil/Inputs/libfat-test.a \
+RUN: --arch=i686 | FileCheck %s --check-prefix=I686
+I686-NOT: 64-bit
+I686: file format Mach-O 32-bit i386
+I686-NOT: 64-bit
+
RUN: llvm-dwarfdump --debug-info %S/../../dsymutil/Inputs/libfat-test.a \
RUN: --arch=i386 --arch=x86_64 | FileCheck %s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60252.193664.patch
Type: text/x-patch
Size: 1297 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190404/60d1deee/attachment.bin>
More information about the llvm-commits
mailing list