[PATCH] D60081: [COFF] Fix delay import directory iterator

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

A few more nits.



================
Comment at: lld/test/COFF/Inputs/delayimporttables-exe.yaml:1
+--- !COFF
+header:
----------------
You can move this contents to COFF/delayimporttables.test (and you probably should rename it delayimporttables.yaml)


================
Comment at: lld/test/COFF/Inputs/delayimporttables-exe.yaml:27-44
+  - Name:            .xdata
+    Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ ]
+    Alignment:       4
+    SectionData:     010D01000D420000
+  - Name:            .pdata
+    Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_READ ]
+    Alignment:       4
----------------
I believe you can remove them.


================
Comment at: lld/test/COFF/Inputs/delayimporttables-exe.yaml:58-69
+  - Name:            '.text$mn'
+    Value:           0
+    SectionNumber:   2
+    SimpleType:      IMAGE_SYM_TYPE_NULL
+    ComplexType:     IMAGE_SYM_DTYPE_NULL
+    StorageClass:    IMAGE_SYM_CLASS_STATIC
+    SectionDefinition:
----------------
This one as well.


================
Comment at: lld/test/COFF/Inputs/delayimporttables-exe.yaml:106-147
+  - Name:            '$LN3'
+    Value:           0
+    SectionNumber:   2
+    SimpleType:      IMAGE_SYM_TYPE_NULL
+    ComplexType:     IMAGE_SYM_DTYPE_NULL
+    StorageClass:    IMAGE_SYM_CLASS_LABEL
+  - Name:            .xdata
----------------
Ditto.


================
Comment at: lld/test/COFF/delayimporttables.test:10
+#      CHECK:Format: COFF-x86-64
+# CHECK-NEXT:Arch: x86_64
+# CHECK-NEXT:AddressSize: 64bit
----------------
Add a space after the first `:`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60081/new/

https://reviews.llvm.org/D60081