[PATCH] D60239: [Lint] Permit aliasing noalias readonly arguments

[Josh Stone via Phabricator via llvm-commits]

cuviper created this revision.
cuviper added a reviewer: hfinkel.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

If two arguments are both readonly, then they have no memory dependency
that would violate noalias, even if they do actually overlap.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60239

Files:
  llvm/lib/Analysis/Lint.cpp
  llvm/test/Analysis/Lint/noalias-readonly.ll


Index: llvm/test/Analysis/Lint/noalias-readonly.ll
===================================================================
--- /dev/null
+++ llvm/test/Analysis/Lint/noalias-readonly.ll
@@ -0,0 +1,40 @@
+; RUN: opt < %s -lint -disable-output 2>&1 | FileCheck %s
+
+declare void @f1(i8* noalias readonly, i8*)
+
+define void @f2(i8* %a) {
+entry:
+  call void @f1(i8* %a, i8* %a)
+  ret void
+}
+
+; Lint should complain about us passing %a to both arguments, since the noalias
+; argument may depend on writes to the other.
+; CHECK: Unusual: noalias argument aliases another argument
+; CHECK-NEXT: call void @f1(i8* %a, i8* %a)
+
+declare void @f3(i8* noalias, i8* readonly)
+
+define void @f4(i8* %a) {
+entry:
+  call void @f3(i8* %a, i8* %a)
+  ret void
+}
+
+; Lint should complain about us passing %a to both arguments, since writes to
+; the noalias argument may cause a dependency for the other.
+; CHECK: Unusual: noalias argument aliases another argument
+; CHECK-NEXT: call void @f3(i8* %a, i8* %a)
+
+declare void @f5(i8* noalias readonly, i8* readonly)
+
+define void @f6(i8* %a) {
+entry:
+  call void @f5(i8* %a, i8* %a)
+  ret void
+}
+
+; Lint should not complain about passing %a to both arguments even if one is
+; noalias, since they are both readonly and thus have no dependence.
+; CHECK-NOT: Unusual: noalias argument aliases another argument
+; CHECK-NOT: call void @f5(i8* %a, i8* %a)
Index: llvm/lib/Analysis/Lint.cpp
===================================================================
--- llvm/lib/Analysis/Lint.cpp
+++ llvm/lib/Analysis/Lint.cpp
@@ -267,10 +267,14 @@
         if (Formal->hasNoAliasAttr() && Actual->getType()->isPointerTy()) {
           AttributeList PAL = CS.getAttributes();
           unsigned ArgNo = 0;
-          for (CallSite::arg_iterator BI = CS.arg_begin(); BI != AE; ++BI) {
+          for (CallSite::arg_iterator BI = CS.arg_begin(); BI != AE;
+               ++BI, ++ArgNo) {
             // Skip ByVal arguments since they will be memcpy'd to the callee's
             // stack so we're not really passing the pointer anyway.
-            if (PAL.hasParamAttribute(ArgNo++, Attribute::ByVal))
+            if (PAL.hasParamAttribute(ArgNo, Attribute::ByVal))
+              continue;
+            // If both arguments are readonly, they have no dependence.
+            if (Formal->onlyReadsMemory() && CS.onlyReadsMemory(ArgNo))
               continue;
             if (AI != BI && (*BI)->getType()->isPointerTy()) {
               AliasResult Result = AA->alias(*AI, *BI);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60239.193625.patch
Type: text/x-patch
Size: 2532 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190403/3ee6602d/attachment.bin>