[PATCH] D59942: [DebugInfo] Track multiple registers in DbgEntityHistoryCalculator

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:161
   if (HistMap.startDbgValue(Var, DV, NewIndex)) {
+    DenseMap<unsigned, bool> TrackedRegs;
+
----------------
dstenb wrote:
> aprantl wrote:
> > Should this be a SmallDenseMap?
> Sorry, yes, this was totally overkill. For example, in a RelWithDebInfo+asan build the maximum size of the map was 11, and in 99.98% of the cases the size of the map was less than or equal 2.
So should it be size 2 then? ;-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59942/new/

https://reviews.llvm.org/D59942