[PATCH] D60227: [Remarks] Add string deduplication using a string table

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg marked 2 inline comments as done.
thegameg added inline comments.


================
Comment at: llvm/include/llvm/Remarks/RemarkStringTable.h:46
+  /// It returns an unique ID of the string. If the string is not in the table,
+  /// the behavior is undefined.
+  unsigned get(StringRef Str) const;
----------------
paquette wrote:
> Why undefined?
This class is supposed to be used by having a sequence of calls to add(...) and then serialize(OS). After thinking a bit more I will just remove the get function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60227/new/

https://reviews.llvm.org/D60227