[PATCH] D53945: [TextAPI] TBD Reader/Writer

Wed Apr 3 13:35:13 PDT 2019

mstorsjo added inline comments.

================
Comment at: llvm/include/llvm/TextAPI/MachO/Architecture.def:17
+///
+ARCHINFO(i386, MachO::CPU_TYPE_I386, MachO::CPU_SUBTYPE_I386_ALL)
+ARCHINFO(x86_64, MachO::CPU_TYPE_X86_64, MachO::CPU_SUBTYPE_X86_64_ALL)
----------------
This seemed to break compilation of LLVM for i386.

When targeting i386, both GCC and Clang define `i386` (without underscores), see e.g. https://github.com/llvm-project/clang/blob/master/lib/Basic/Targets/X86.cpp#L897.

The fact that `i386` is defined and expands to `1` breaks this ARCHINFO case, as `1` isn't a valid name in enum class Architecture.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53945/new/

https://reviews.llvm.org/D53945