[PATCH] D60231: Include invoke'd functions for recursive extract

Keno Fischer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 13:35:11 PDT 2019


loladiro added a comment.

Inline comment on implementation. The functionality looks fine to me.



================
Comment at: tools/llvm-extract/llvm-extract.cpp:274
+          Function *CF = nullptr;
+          if(auto *CI = dyn_cast<CallInst>(&I))
+            CF = CI->getCalledFunction();
----------------
Just use `CallBase` here instead of enumerating the subclasses thereof?
Also the formatting, looks slightly off.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60231/new/

https://reviews.llvm.org/D60231





More information about the llvm-commits mailing list